Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fixed tutorial warnings #14472

Merged
merged 4 commits into from
Mar 22, 2019
Merged

Conversation

NRauschmayr
Copy link
Contributor

Description

I fixed the tutorials that are currently breaking the nightly tests.
#14401

I also removed the matrix-factorization example that was failing for some other reason. We will redo this tutorial.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • [ x] Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@NRauschmayr NRauschmayr requested a review from szha as a code owner March 19, 2019 17:38
@pinaraws
Copy link

pinaraws commented Mar 19, 2019

Thank you for your contribution @NRauschmayr!
Some tests are failing, please have a look.

@mxnet-label-bot add[pr-work-in-progress]

@marcoabreu marcoabreu added the pr-work-in-progress PR is still work in progress label Mar 19, 2019
@lebeg
Copy link
Contributor

lebeg commented Mar 21, 2019

The status didn't get updated, but validation is fine. I've retriggered this part, should be good shortly.

Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix : )

@ThomasDelteil ThomasDelteil merged commit 29e13b4 into apache:master Mar 22, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
* Fixed tutorial warnings

* Remove test case for matrix factorization tutorial

* trigger

* Update hybrid.md
ZhennanQin pushed a commit to ZhennanQin/incubator-mxnet that referenced this pull request Apr 3, 2019
* Fixed tutorial warnings

* Remove test case for matrix factorization tutorial

* trigger

* Update hybrid.md
nswamy pushed a commit that referenced this pull request Apr 5, 2019
* Fixed tutorial warnings

* Remove test case for matrix factorization tutorial

* trigger

* Update hybrid.md
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
* Fixed tutorial warnings

* Remove test case for matrix factorization tutorial

* trigger

* Update hybrid.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-work-in-progress PR is still work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants